GH-46488 [C#] Switch to license expression #46624
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
thompson-tomo
changed the title
|
|
thompson-tomo
changed the title
kou
changed the title
| @@ -45,7 +45,7 @@ | |||
| <Authors>The Apache Software Foundation</Authors> | |||
| <PackageIcon>feather.png</PackageIcon> | |||
| <!-- We can't use PackageLicenseExpression; the license file also contains 3rd-party notices. --> | |||
There was a problem hiding this comment.
Yes but when you review the third party notices, they are referring to the other languages ie cpp. At the same time on reviewing the source code, I couldn't find a source file which didn't have the Apache licence header or wasn't auto generated. Based on that it should be possible to move most if not all packages from the deprecated property to the replacement.
There was a problem hiding this comment.
At the same time on reviewing the source code, I couldn't find a source file which didn't have the Apache licence header or wasn't auto generated.
How did you do it? Could you clarify it to clear our license?
BTW, we'll move csharp/ in apache/arrow to apache/arrow-dotnet: apache/arrow-dotnet#1
Can we work on this after it?
There was a problem hiding this comment.
How did you do it? Could you clarify it to clear our license?
I manually went through checking files in each of the projects including the sub folders.
BTW, we'll move csharp/ in apache/arrow to apache/arrow-dotnet: apache/arrow-dotnet#1
Can we work on this after it?
sure that is fine
What changes are included in this PR?
Update to csproj property
Are these changes tested?
Yes
Are there any user-facing changes?
No
Closes #46488