GH-46719: [R] Add 32 and 64 bit Decimal types #46720
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: R
awaiting committer review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
32 and 64 bit Decimal types were added in C++ in #43957 but haven't been implemented in R yet
What changes are included in this PR?
Implements them in R
Are these changes tested?
Yup
Are there any user-facing changes?
Yeah, new types but also the implicit downcasting so we should think about how to communicate this
TODOs:
Update the types vignette
GitHub Issue: [R] Add 32 and 64 bit Decimal types #46719