-
Notifications
You must be signed in to change notification settings - Fork 3.7k
GH-46459: [C++] Make some arrow/util headers internal #46721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@github-actions crossbow submit -g cpp -g python |
Revision: 47915f9 Submitted crossbow builds: ursacomputing/crossbow @ actions-82f8f73fc8 |
lgtm! this will break the meson configuration since those explicitly list headers to be installed. Feel free to update that if you care, or I can do as a follow up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I've fixed Meson errors.
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5a4c8b6. There were 64 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Historically, we've been lax about selecting which APIs are public. A lot of internal APIs are exposed publicly.
What changes are included in this PR?
Make some headers in
arrow/util
internal. They won't be installed and so won't be available for third-party usage.Note that this represents a subset of all internal APIs in
arrow/util
, as some of them are included in other public headers.Are these changes tested?
Yes, by existing CI configurations.
Are there any user-facing changes?
Unless the user was relying on internal APIs, there should not be any change.
arrow/util
headers for internal APIs #46459