[DNM] GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh #46727

hiroyuki-sato · 2025-06-06T05:38:35Z

Rationale for this change

This is the sub issue #44748.

SC2046 -- Quote this to prevent word splitt...
SC2206 -- Quote to prevent word splitting/g...
SC2086 -- Double quote to prevent globbing ...

In ci/scripts/conan_build.sh line 32:
  conan_args+=(--options arrow/*:parquet=${ARROW_CONAN_PARQUET})
                                         ^--------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 33:
  conan_args+=(--options arrow/*:with_thrift=${ARROW_CONAN_PARQUET})
                                             ^--------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 34:
  conan_args+=(--options arrow/*:with_boost=${ARROW_CONAN_PARQUET})
                                            ^--------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 37:
  conan_args+=(--options arrow/*:with_brotli=${ARROW_CONAN_WITH_BROTLI})
                                             ^------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 40:
  conan_args+=(--options arrow/*:with_bz2=${ARROW_CONAN_WITH_BZ2})
                                          ^---------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 43:
  conan_args+=(--options arrow/*:with_flight_rpc=${ARROW_CONAN_WITH_FLIGHT_RPC})
                                                 ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 44:
  conan_args+=(--options arrow/*:with_grpc=${ARROW_CONAN_WITH_FLIGHT_RPC})
                                           ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 45:
  conan_args+=(--options arrow/*:with_protobuf=${ARROW_CONAN_WITH_FLIGHT_RPC})
                                               ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 46:
  conan_args+=(--options arrow/*:with_re2=${ARROW_CONAN_WITH_FLIGHT_RPC})
                                          ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 49:
  conan_args+=(--options arrow/*:with_glog=${ARROW_CONAN_WITH_GLOG})
                                           ^----------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 52:
  conan_args+=(--options arrow/*:with_jemalloc=${ARROW_CONAN_WITH_JEMALLOC})
                                               ^--------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 55:
  conan_args+=(--options arrow/*:with_json=${ARROW_CONAN_WITH_JSON})
                                           ^----------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 58:
  conan_args+=(--options arrow/*:with_lz4=${ARROW_CONAN_WITH_LZ4})
                                          ^---------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 61:
  conan_args+=(--options arrow/*:with_snappy=${ARROW_CONAN_WITH_SNAPPY})
                                             ^------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 64:
  conan_args+=(--options arrow/*:with_zstd=${ARROW_CONAN_WITH_ZSTD})
                                           ^----------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 67:
version=$(grep '^set(ARROW_VERSION ' ${ARROW_HOME}/cpp/CMakeLists.txt | \
                                     ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
version=$(grep '^set(ARROW_VERSION ' "${ARROW_HOME}"/cpp/CMakeLists.txt | \


In ci/scripts/conan_build.sh line 69:
conan_args+=(--version ${version})
                       ^--------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 72:
rm -rf ${build_dir}/conan || sudo rm -rf ${build_dir}/conan
       ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
rm -rf "${build_dir}"/conan || sudo rm -rf "${build_dir}"/conan


In ci/scripts/conan_build.sh line 73:
mkdir -p ${build_dir}/conan || sudo mkdir -p ${build_dir}/conan
         ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
mkdir -p "${build_dir}"/conan || sudo mkdir -p "${build_dir}"/conan


In ci/scripts/conan_build.sh line 74:
if [ -w ${build_dir} ]; then
        ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
if [ -w "${build_dir}" ]; then


In ci/scripts/conan_build.sh line 75:
  cp -a ${source_dir}/ci/conan/* ${build_dir}/conan/
        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  cp -a "${source_dir}"/ci/conan/* "${build_dir}"/conan/


In ci/scripts/conan_build.sh line 77:
  sudo cp -a ${source_dir}/ci/conan/* ${build_dir}/conan/
             ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  sudo cp -a "${source_dir}"/ci/conan/* "${build_dir}"/conan/


In ci/scripts/conan_build.sh line 78:
  sudo chown -R $(id -u):$(id -g) ${build_dir}/conan/
                ^------^ SC2046 (warning): Quote this to prevent word splitting.
                         ^------^ SC2046 (warning): Quote this to prevent word splitting.
                                  ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  sudo chown -R $(id -u):$(id -g) "${build_dir}"/conan/


In ci/scripts/conan_build.sh line 80:
cd ${build_dir}/conan/all
   ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
cd "${build_dir}"/conan/all

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2206 -- Quote to prevent word splitting/g...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

Add quote like "${ARROW_CONAN_PARQUET}"

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

GitHub Issue: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh #46726

…an_build.sh

github-actions · 2025-06-06T05:39:02Z

⚠️ GitHub issue #46726 has been automatically assigned in GitHub to PR creator.

kou · 2025-06-06T06:31:18Z

@github-actions crossbow submit -g conan

kou · 2025-06-06T06:31:50Z

ci/scripts/conan_build.sh

-  conan_args+=(--options arrow/*:parquet=${ARROW_CONAN_PARQUET})
-  conan_args+=(--options arrow/*:with_thrift=${ARROW_CONAN_PARQUET})
-  conan_args+=(--options arrow/*:with_boost=${ARROW_CONAN_PARQUET})
+  conan_args+=(--options arrow/*:parquet="${ARROW_CONAN_PARQUET}")


Suggested change

conan_args+=(--options arrow/*:parquet="${ARROW_CONAN_PARQUET}")

conan_args+=(--options "arrow/*:parquet=${ARROW_CONAN_PARQUET}")

I want to double check just in case.
Does the '*' character is just the character not a wildcard character ?

And suggested change means not only parquet but also with_thrift and with_boost too?

conan_args+=(--options "arrow/*:parquet=${ARROW_CONAN_PARQUET}") conan_args+=(--options "arrow/*:with_thrift=${ARROW_CONAN_PARQUET}") conan_args+=(--options "arrow/*:with_boost=${ARROW_CONAN_PARQUET}")

and the rest of belows

if [ -n "${ARROW_CONAN_WITH_GLOG:-}" ]; then conan_args+=(--options arrow/*:with_glog="${ARROW_CONAN_WITH_GLOG}") fi if [ -n "${ARROW_CONAN_WITH_JEMALLOC:-}" ]; then conan_args+=(--options arrow/*:with_jemalloc="${ARROW_CONAN_WITH_JEMALLOC}") fi if [ -n "${ARROW_CONAN_WITH_JSON:-}" ]; then conan_args+=(--options arrow/*:with_json="${ARROW_CONAN_WITH_JSON}") fi if [ -n "${ARROW_CONAN_WITH_LZ4:-}" ]; then conan_args+=(--options arrow/*:with_lz4="${ARROW_CONAN_WITH_LZ4}") fi if [ -n "${ARROW_CONAN_WITH_SNAPPY:-}" ]; then conan_args+=(--options arrow/*:with_snappy="${ARROW_CONAN_WITH_SNAPPY}") fi if [ -n "${ARROW_CONAN_WITH_ZSTD:-}" ]; then conan_args+=(--options arrow/*:with_zstd="${ARROW_CONAN_WITH_ZSTD}") fi

Thanks! done.

ci/scripts/conan_build.sh

github-actions · 2025-06-06T06:33:42Z

Revision: 07e75eb

Submitted crossbow builds: ursacomputing/crossbow @ actions-fad6f67540

Task	Status
conan-maximum
conan-minimum

Co-authored-by: Sutou Kouhei <[email protected]>

hiroyuki-sato · 2025-06-06T08:42:37Z

It seems that conan-minimum can't find RapidJSON package.

https://github.com/ursacomputing/crossbow/actions/runs/15484349076/job/43595828887#step:6:1006

-- Conan: Including build module from '/root/.conan2/p/opens291bcb59a86d6/p/lib/cmake/conan-official-openssl-variables.cmake'
-- Providing CMake module for FindThriftAlt as part of Parquet CMake package
-- pkg-config package for thrift that is used by parquet for static link isn't found
CMake Warning at cmake_modules/FindRapidJSONAlt.cmake:29 (find_package):
  By not providing "FindRapidJSON.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "RapidJSON", but CMake did not find one.

  Could not find a package configuration file provided by "RapidJSON"
  (requested version 1.1.0) with any of the following names:

    RapidJSONConfig.cmake
    rapidjson-config.cmake

  Add the installation prefix of "RapidJSON" to CMAKE_PREFIX_PATH or set
  "RapidJSON_DIR" to a directory containing one of the above files.  If
  "RapidJSON" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  cmake_modules/ThirdpartyToolchain.cmake:310 (find_package)
  cmake_modules/ThirdpartyToolchain.cmake:2538 (resolve_dependency)
  CMakeLists.txt:618 (include)


CMake Error at /root/.conan2/p/cmakee7c682f30a1a9/p/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find RapidJSONAlt (missing: RAPIDJSON_INCLUDE_DIR) (Required is
  at least version "1.1.0")
Call Stack (most recent call first):
  /root/.conan2/p/cmakee7c682f30a1a9/p/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)

kou · 2025-06-06T22:56:10Z

Let's fix the failure before this.

…ipts/conan_build.sh" This reverts commit 07e75eb~1..

hiroyuki-sato · 2025-06-07T01:53:39Z

Thanks. I reverted all commits for testing conan-minimum build failure. After resolve build failure I will modify quote again.

hiroyuki-sato · 2025-06-07T01:53:45Z

@github-actions crossbow submit -g conan

github-actions · 2025-06-07T01:55:59Z

Revision: c488ecb

Submitted crossbow builds: ursacomputing/crossbow @ actions-e4ffbae60d

Task	Status
conan-maximum
conan-minimum

…ripts/conan_build.sh" This reverts commit c488ecb.

hiroyuki-sato · 2025-06-07T02:44:46Z

conan-minimum build failure unrelated this change.

apacheGH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/con…

07e75eb

…an_build.sh

hiroyuki-sato requested review from assignUser, jonkeane, kou and raulcd as code owners June 6, 2025 05:38

github-actions bot added the awaiting review Awaiting review label Jun 6, 2025

kou reviewed Jun 6, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jun 6, 2025

Update ci/scripts/conan_build.sh

6fd736d

Co-authored-by: Sutou Kouhei <[email protected]>

github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Jun 6, 2025

Fix review comments

511c3de

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 6, 2025

Fix review comments

24942b4

Revert "apacheGH-46726: [CI][Dev] fix shellcheck errors in the ci/scr…

c488ecb

…ipts/conan_build.sh" This reverts commit 07e75eb~1..

Reapply "apacheGH-46726: [CI][Dev] fix shellcheck errors in the ci/sc…

7bd880b

…ripts/conan_build.sh" This reverts commit c488ecb.

hiroyuki-sato changed the title ~~GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh~~ [DNN] GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh Jun 7, 2025

hiroyuki-sato changed the title ~~[DNN] GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh~~ [DNM] GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh Jun 7, 2025

hiroyuki-sato mentioned this pull request Jun 7, 2025

[CI] conan-minimum build failure with RapidJSON missing error #46736

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DNM] GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh #46727

[DNM] GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh #46727

Uh oh!

hiroyuki-sato commented Jun 6, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

kou commented Jun 6, 2025

Uh oh!

kou Jun 6, 2025

Uh oh!

hiroyuki-sato Jun 6, 2025 •

edited

Loading

Uh oh!

kou Jun 6, 2025

Uh oh!

hiroyuki-sato Jun 6, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

hiroyuki-sato commented Jun 6, 2025

Uh oh!

kou commented Jun 6, 2025

Uh oh!

hiroyuki-sato commented Jun 7, 2025

Uh oh!

hiroyuki-sato commented Jun 7, 2025

Uh oh!

github-actions bot commented Jun 7, 2025

Uh oh!

hiroyuki-sato commented Jun 7, 2025

Uh oh!

Uh oh!

	conan_args+=(--options arrow/*:parquet="${ARROW_CONAN_PARQUET}")
	conan_args+=(--options "arrow/*:parquet=${ARROW_CONAN_PARQUET}")

[DNM] GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh #46727

Are you sure you want to change the base?

[DNM] GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh #46727

Uh oh!

Conversation

hiroyuki-sato commented Jun 6, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

kou commented Jun 6, 2025

Uh oh!

kou Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

hiroyuki-sato Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kou Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

hiroyuki-sato Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

hiroyuki-sato commented Jun 6, 2025

Uh oh!

kou commented Jun 6, 2025

Uh oh!

hiroyuki-sato commented Jun 7, 2025

Uh oh!

hiroyuki-sato commented Jun 7, 2025

Uh oh!

github-actions bot commented Jun 7, 2025

Uh oh!

hiroyuki-sato commented Jun 7, 2025

Uh oh!

Uh oh!

hiroyuki-sato commented Jun 6, 2025 •

edited by github-actions bot

Loading

hiroyuki-sato Jun 6, 2025 •

edited

Loading