Skip to content

GH-46094: [C++][Docs] Add note to RleDecoder::Get's doc comment #46874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

hadrian-reppas
Copy link
Contributor

@hadrian-reppas hadrian-reppas commented Jun 20, 2025

Rationale for this change

The behavior of RleDecoder::Get caused some confusion in #46094.

What changes are included in this PR?

Improvement to RleDecoder::Get's doc comment.

Are these changes tested?

N/A

Are there any user-facing changes?

No.

@kou kou changed the title MINOR: Add note to RleDecoder::Get's doc comment GH-46094: [C++][Docs] Add note to RleDecoder::Get's doc comment Jun 20, 2025
Copy link

⚠️ GitHub issue #46094 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member

kou commented Jun 20, 2025

@github-actions crossbow submit preview-docs

Copy link

Revision: 593a63a

Submitted crossbow builds: ursacomputing/crossbow @ actions-ebc2a97298

Task Status
preview-docs GitHub Actions

@kou
Copy link
Member

kou commented Jun 21, 2025

Could you rebase on main?

@hadrian-reppas
Copy link
Contributor Author

Done!

@kou
Copy link
Member

kou commented Jun 22, 2025

@github-actions crossbow submit preview-docs

Copy link

Revision: d82cf38

Submitted crossbow builds: ursacomputing/crossbow @ actions-bbae524876

Task Status
preview-docs GitHub Actions

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 3573f54 into apache:main Jun 23, 2025
36 of 37 checks passed
@kou kou removed the awaiting review Awaiting review label Jun 23, 2025
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 3573f54.

There were 119 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants