GH-46375: [C++] Add adapters/orc directory to Meson #46906
Conversation
cpp/subprojects/orc.wrap
Outdated
| # under the License. | ||
|
|
||
| [wrap-file] | ||
| directory = orc-45b4014b61912dcd22eae69a0528a8b8888377d6 |
There was a problem hiding this comment.
This currently points to a development version of Apache ORC. The next full version to support Meson natively will be 2.2, which may be released in a few months (?). At that point in time, we should be able to switch over to an official Meson wrap release
github-actions
bot
added
awaiting committer review
|
I don't believe the AppVeyor failure is related |
|
I'm not familiar with Meson internals but it looks reasonable to me. cc @kou |
|
|
||
| [wrap-file] | ||
| directory = orc-15d86dfcad6fc80ee24cf785419a820a55db103b | ||
| source_url = https://github.com/apache/orc/archive/15d86dfcad6fc80ee24cf785419a820a55db103b.tar.gz |
There was a problem hiding this comment.
Can we use a released version instead?
There was a problem hiding this comment.
Not yet - a release with the Meson configuration hasn't happened (it's brand new)
There was a problem hiding this comment.
Can we merge this PR after the new ORC release?
There was a problem hiding this comment.
Sure we can wait. I know originally the next release for Orc was planned far out, but there have been discussions for it happening sooner (next month or so).
Will keep tabs on that discussion
There was a problem hiding this comment.
Hmm actually it would be good if we reconsider for now. The orc implementation here is a dependency for the dataset work, which in turn can unlock substrait work, which is the last component needed before we can more seriously look at the Python build system again.
There are of course ways to work around that, but I think going in a linear fashion is the easiest way to avoid missing anything compared against CMake
There was a problem hiding this comment.
OK. But can we do this after 21.0.0 feature freeze?
We should not release a version that depends on non "official" Apache product releases.
github-actions
bot
added
awaiting changes
Rationale for this change
Apache ORC now has native support for Meson, so we can rather easily add support now in Arrow
What changes are included in this PR?
This integrates the adapters/orc directory into the Meson configuration
Are these changes tested?
Yes
Are there any user-facing changes?
No