GH-46869: [C++][Parquet] Add arrow::Result version of parquet::arrow::FileReader::GetRecordBatchReader()
#46932
+60
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r::GetRecordBatchReader() Signed-off-by: Ziy1-Tan <[email protected]>
Ziy1-Tan
changed the title
arrow::Result version of parquet::arrow::FileReader::GetRecordBatchReader()
|
It would be better to change all test cases to use new non-deprecated apis. |
It is only used by example before: arrow/cpp/examples/arrow/parquet_read_write.cc Lines 69 to 70 in ed13ced |
wgtmac
requested changes
Jun 30, 2025
| @@ -191,13 +191,53 @@ class PARQUET_EXPORT FileReader { | |||
| /// | |||
| /// \returns error Status if either row_group_indices or column_indices | |||
| /// contains an invalid index | |||
| /// \deprecated Deprecated in future release. Use arrow::Result version instead. | |||
| ARROW_DEPRECATED("Deprecated in future release. Use arrow::Result version instead.") | |||
There was a problem hiding this comment.
Can we specify a clear deprecated version? It should be 21.0.0 for now. (Note that there will be a feature freeze on July 1st)
| /// \returns error Result if either row_group_indices or column_indices | ||
| /// contains an invalid index | ||
| virtual ::arrow::Result<std::shared_ptr<::arrow::RecordBatchReader>> | ||
| GetRecordBatchReaderSharedPtr(const std::vector<int>& row_group_indices, |
There was a problem hiding this comment.
Suggested change
| GetRecordBatchReaderSharedPtr(const std::vector<int>& row_group_indices, | |
| GetRecordBatchReader(const std::vector<int>& row_group_indices, |
Can we avoid adding SharedPtr to be consistent?
github-actions
bot
added
awaiting committer review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We're migrating arrow::Status + output variable API to arrow::Result API.
What changes are included in this PR?
arrow::Result<std::shared_ptr<arrow::RecordBatchReader parquet::arrow::FileReader::GetRecordBatchReaderSharedPtr()arrow::Status parquet::arrow::FileReadeder::GetRecordBatchReader()arrow::Resultversion in our code baseAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.
This PR includes breaking changes to public APIs.
GetRecordBatchReader()-->GetRecordBatchReaderSharedPtr(), because overloading is not possible if only the return value is differentResult<shared_ptr>versions ofparquet:arrow::FileReader::GetRecordBatchReader()#46869