GH-47016: [C++][FlightSQL] Fix negative timestamps to date types #47017
+88
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
|
Thanks for opening this PR @Antropovi ! I have tested your code changes and it supports dates before 1970 to 1400, but not dates before 1400. I.e., dates with 1399 and earlier years are not yet supported. Will the PR include a fix for dates before 1400 as well? 🙂 By the way, there is an issue for date and timestamp types before 1400 as well: #46978 |
alinaliBQ
added a commit
to Bit-Quill/arrow
that referenced
this pull request
Jul 7, 2025
Testing changes at apache#47017
kou
reviewed
Jul 8, 2025
| @@ -17,6 +17,7 @@ | |||
|
|
|||
| #include "odbcabstraction/calendar_utils.h" | |||
|
|
|||
| #include <boost/date_time/posix_time/posix_time.hpp> | |||
There was a problem hiding this comment.
Can we use std::chrono instead of Boost? (Currently, Arrow C++ requires C++17 but we'll require C++20 soon #44792 . So we can use C++20 in ODBC support.)
In general, we want to avoid using Boost as much as possible. It's difficult to maintain.
github-actions
bot
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix negative timestamps from arrow to date structs when using flightsql odbc.
Are these changes tested?
Yes
Are there any user-facing changes?
No