GH-47029: [Archery] Fix generation of RunEndsField #47034
+20
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Alex-PLACET
force-pushed
the
archery_fix_run_end_encoded_generation
branch
from
9bd32c1 to
e558efa
Compare
Alex-PLACET
force-pushed
the
archery_fix_run_end_encoded_generation
branch
from
ef17707 to
a7b4472
Compare
Alex-PLACET
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
pitrou
reviewed
Jul 10, 2025
|
|
||
| if name is None: | ||
| name = self.name | ||
| return PrimitiveColumn(name, size, is_valid, values) | ||
| return PrimitiveColumn(name, int(runs_count), is_valid, values) |
There was a problem hiding this comment.
This seems ok on the face of it, but needs an adaptation on the C++ side if we want the decoded REE array to have a length equal to runs_count.
The alternative would be pass to runs_count here, which might also work better for Go and nanoarrow (the two other Arrow implementations that support REE currently).
@paleolimbot @zeroshade What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix incorrect array generation in Archery
What changes are included in this PR?
Fix an issue issue in Archery Integration which generate wrong number of values for run-end encoded.
Are these changes tested?
In the CI
Are there any user-facing changes?
The JSONs generated by Archery integration