GH-47039: [C++] Bump RapidJSON dependency in Meson configuration #47041
+26
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kou
changed the title
|
How about migrating to simdjson from RapidJSON instead? |
|
Sure I can take a look. Although I think there is still value in bumping this in the meantime, since it was done for CMake too |
WillAyd
force-pushed
the
fix-meson-rapidjson
branch
from
76afe86 to
1a381f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Meson configuration is unusable on gcc 14.2 given issues with the RapidJSON release of 1.1.0 (released in 2016)
What changes are included in this PR?
Bumps the RapidJSON version to a commit hash that matches what is used in CMake by default
Are these changes tested?
Yes
Are there any user-facing changes?
No