Skip to content

GH-47099: [C++][Parquet] parquet/platform.h is missing pragma warning(pop) #47114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

behrisch
Copy link

@behrisch behrisch commented Jul 15, 2025

Rationale for this change

The missing pragma is causing warnings downstream see #47099

What changes are included in this PR?

Adding the missing pragma warning(pop)

Are these changes tested?

I hope for the CI to do that ;-)

Are there any user-facing changes?

The developer should see less warnings otherwise, no.

@behrisch behrisch requested a review from wgtmac as a code owner July 15, 2025 15:55
Copy link

⚠️ GitHub issue #47099 has been automatically assigned in GitHub to PR creator.

@wgtmac
Copy link
Member

wgtmac commented Jul 16, 2025

Could you try to add following code to fix https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/52408405

diff --git a/cpp/src/parquet/exception.h b/cpp/src/parquet/exception.h
index 46f5595dd1..55b769c978 100644
--- a/cpp/src/parquet/exception.h
+++ b/cpp/src/parquet/exception.h
@@ -84,7 +84,7 @@
 
 namespace parquet {
 
-class ParquetException : public std::exception {
+class PARQUET_EXPORT ParquetException : public std::exception {
  public:
   PARQUET_NORETURN static void EofException(const std::string& msg = "") {
     static std::string prefix = "Unexpected end of stream";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants