-
Notifications
You must be signed in to change notification settings - Fork 92
publish asf-site branch #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Humbedooh Doesn't the publish stanza need to be added to the asf-site branch for the publish to actually take place? |
You are right in that. The publish block needs to be present in the branch that is published |
@Humbedooh So does the stanza need to be in the main branch at all? |
configuration moved to the right location to get to asf-website branch: good catch |
This asf-branch is currently set up differently from most other projects. Normally, the website data is rooted in a sub-directory of the branch, e.g. content/ or output/ This allows files such as .asf.yaml and README.md to be maintained locally, instead of including them in the source build. |
I think the current layout is likely to be confusing for maintainers who are used to the way other asf-site branches are set up. e.g. if anyone tries to add a README directly to the site, it will disappear when the site is next regenerated |
we are clearly not looking at the same lines of https://infra-reports.apache.org/#sitesource
who are the maintainers? source (= the thing people are supposed to update) is default branch called classical I don't get what can be confusing to anybody trying to propose a PR: let's be serious a minute, please |
Sorry, I was not entirely clear. I was referring to the asf-site branch. Generally, the website is stored in the content/ or output/ directory of the asf-site branch, rather than at top level. Such files are specific to the branch, and should therefore be maintained in the branch. That is why I am against this PR; the .asf.yaml file should be maintained as part of the asf-site branch, not here in the source branch. |
simply stop nitpicking: no, your detailed taste is not a must |
The asf-site branch does not have a README.md; it would help to have one. Does it really make sense to have to create that in a different branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR conflates two separate changes, and should be split up.
Also, any change to the Attic site publication can affect how the Attic banners are generated; there is a script to potentially keep the SVN repo in sync, but it has yet to be included in any site updates.
I can provide PR to move the output, as I have tested it already in a fork. |
I use then we can continue our modernization plan I'll merge #4 , I'll merge the current "now documentation only" one, and create the important one = activate publication (now done in |
@Humbedooh can you please check this please?
Attic site is currently published from svnwcsub https://svn.apache.org/repos/asf/attic/site/docs/ after buildbot https://ci2.apache.org/#/builders/16
can you confirm that:
this configuration will switch to publishing from https://github.com/apache/attic/tree/asf-site (that is built by GitHub Action)?
that the content from
/www/attic.apache.org
https://github.com/apache/infrastructure-p6/blob/production/modules/svnwcsub/files/svnwcsub.conf#L32 will still be published at the same location, even if it's from Git instead of svn? (it is used for attic banner on website)we'll have also to stop buildbot after the change, as it will not be used any more
FTR: we'll continue to update and use content from https://svn.apache.org/repos/asf/attic/site/cwiki_retired/ for sometime for cwiki banner