Skip to content

Change some notifications rules. #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025

Conversation

Gujiawei-Edinburgh
Copy link
Contributor

  1. change some notifications rules.

@coveralls
Copy link

coveralls commented Jul 8, 2025

Pull Request Test Coverage Report for Build 16158556665

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.04%) to 63.189%

Files with Coverage Reduction New Missed Lines %
org/apache/bifromq/basecrdt/core/internal/CausalCRDTInflater.java 1 92.21%
org/apache/bifromq/basescheduler/Batcher.java 1 83.44%
org/apache/bifromq/demo/plugin/WebHookBasedResourceThrottler.java 1 77.78%
org/apache/bifromq/mqtt/handler/MQTTPersistentSessionHandler.java 1 74.57%
org/apache/bifromq/basecluster/fd/FailureDetector.java 2 88.16%
org/apache/bifromq/basecrdt/service/CRDTCluster.java 2 81.91%
org/apache/bifromq/basekv/raft/RaftNodeStateLeader.java 2 84.91%
org/apache/bifromq/inbox/server/InboxFetchPipeline.java 2 57.21%
org/apache/bifromq/basehlc/HLC.java 3 67.74%
org/apache/bifromq/dist/trie/TopicFilterIterator.java 3 72.52%
Totals Coverage Status
Change from base Build 16113835338: -0.04%
Covered Lines: 23324
Relevant Lines: 35674

💛 - Coveralls

Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As most PR and issue discussions take place on GitHub, we generally archive such notifications to the commit mailing list to minimize unnecessary or duplicate messages on the dev list.

Of course, if the community prefers a different approach, I'm open to that as well.

As long as the process is open and transparent, that's totally fine.

@popduke popduke merged commit 7bc6ee1 into apache:main Jul 9, 2025
4 checks passed
@Gujiawei-Edinburgh Gujiawei-Edinburgh deleted the feat-mailing-list branch July 14, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants