[improve] different bookies do not trigger gcOverreplicatedLedger at the same time #4314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the
gcOverReplicatedLedger
function, there is a configgcOverreplicatedLedgerMaxConcurrentRequests
to control the zk concurrent request of one bookie, which aim to avoid too much pressure on zk.However, if we have so much bookies, and different bookies start at similar time, different bookies would trigger gcOverreplicatedLedger at the same time. This make the request pressure on zk become
maxConcurrentRequests * bookieNums
.I think we can improve this process, make different bookies not trigger gcOverreplicatedLedger at the same time. So that we can avoid
gcOverreplicatedLedgerMaxConcurrentRequests
be a very small value.Changes
define lastOverReplicatedLedgerGcTimeMillis based on
the bookie start time + gcOverReplicatedLedgerIntervalMillis * randomly factor
orthe bookie start time - gcOverReplicatedLedgerIntervalMillis * randomly factor