-
Notifications
You must be signed in to change notification settings - Fork 87
Structured Outputs with Instructor #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few minor changes then we can merge!
], | ||
writes=["generated_topic", "chat_history"], | ||
) | ||
def creator( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add docstring comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding just short docstring comments? But to each one? E.G. the first sentence of this, but for each action. Makes it easier to read/undersatnd the example :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course. My bad. Added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, specifically I meant docstrings to the functions decorated by @action
-- These are the important ones that tell the story. Think you have enough comments in this function!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 📝
Also you'll want to run pre-commit:
|
Done @elijahbenizzy |
Great, thanks, one more comment about docs then I can take over and get the CI to pass (external users aren't allowed to run it now so I can just do this quickly). Then when we merge we can merge this! #248 |
This looks great! Thank you so much. I'm going to:
Really appreciate your contribution 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! As discussed, merging to main then I'll fix real quick.
Using Gemini Flash with Instructor for structured outputs as assigned to me in #240.
Changes
How I tested this
Notes
Checklist