Skip to content

Fix deepresearch dependency #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Fix deepresearch dependency #543

merged 2 commits into from
May 28, 2025

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented May 28, 2025

We missed the tavily dependency. This causes the import to fail on a clean install.

Changes

  • makes it error properly
  • adds optional dependency.

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Important

Fix missing tavily-python dependency for deep-researcher example and add error handling for import failures.

  • Dependency Management:
    • Adds tavily-python to inappexamples in pyproject.toml to fix missing dependency.
  • Error Handling:
    • In utils.py, wraps TavilyClient import in a try-except block to log a warning if tavily is not installed, setting TavilyClient to None on failure.

This description was created by Ellipsis for 88466cf. You can customize this summary. It will automatically update as commits are pushed.

Stefan Krawczyk added 2 commits May 27, 2025 22:46
This will enable the import to work for the module.
And adds tavily to inappexamples.
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 88466cf in 30 seconds. Click for details.
  • Reviewed 35 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. examples/deep-researcher/utils.py:125
  • Draft comment:
    Before using TavilyClient() in tavily_search, ensure it's not None to provide a clear error if the optional dependency isn’t installed.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. pyproject.toml:167
  • Draft comment:
    The optional dependency 'tavily-python' is added under inappexamples, matching the warning message in the code.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_ABUzozl0WbqSwsA2

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

github-actions bot commented May 28, 2025

A preview of is uploaded and can be seen here:

https://burr.dagworks.io/pull/543

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/543/

@elijahbenizzy elijahbenizzy self-requested a review May 28, 2025 05:50
@skrawcz skrawcz merged commit 4a34b6e into main May 28, 2025
11 checks passed
@skrawcz skrawcz deleted the fix_deepresearch_dep branch May 28, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants