-
Notifications
You must be signed in to change notification settings - Fork 130
Explicitly set locale with en_US #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly set locale with en_US #313
Conversation
|
Interesting, do we by any chance remind what kind of issue it generate when we don't force english locale please ? |
|
Well, it's just failing with the test like |
|
@zhfeng sounds like it fails for you in JVM mode on a machine where the default locale is non-english, right? (I just wonder whether it has to do with some recent changes in GraalVM or whether it is an old issue that just popped up now?) |
|
It smells non localized String.format. Could you please try to use the localized format override, ala |
|
Yeah, I will try |
3dc74ae to
7183d11
Compare
|
@aldettinger @ppalaga OK, it works with using |
|
Hmm, but in native build, it is failing Is it related to GaalVM changes? |
|
IIRC somebody mentioned some locale related changes in GraalVM on X. Not sure at all, what kind of they were... |
|
Aha, 2 problems are better than 1 :) "Jul" it looks like, short month notation, strange. Not sure, it's related but maybe it could be tried to play with quarkus native locale: |
|
Now the native test works with adding the following configurations: |
|
IMHO it seems fair enough to add those properties, anyone building with a non US default locale should have tests working. Otherwise we could try format the date independent of Locale, maybe ISO 8601. |
7183d11 to
c4253ba
Compare
Note that the
mainbranch points at the latest stable Camel Quarkus release.Pull requests should be generally send against the
camel-quarkus-mainbranch pointing at the current Camel Quarkus SNAPSHOT.