Skip to content

Add a script to help verify release checks #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Add a script to help verify release checks #32

wants to merge 3 commits into from

Conversation

@michaelsembwever
Copy link
Member

@michaelsembwever michaelsembwever commented Oct 30, 2020

No description provided.

@michaelsembwever
Copy link
Member Author

michaelsembwever commented Oct 30, 2020

@ekaterinadimitrova2

@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch from 7b895cd to 1019ac5 Compare October 30, 2020 19:55
michaelsembwever
michaelsembwever commented Nov 11, 2020
View reviewed changes
michaelsembwever
michaelsembwever commented Nov 11, 2020
View reviewed changes
cassandra-release/cassandra-check-release.sh Outdated
###################

mkdir -p /tmp/$1
cd /tmp/$1
Copy link
Member Author

@michaelsembwever michaelsembwever Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An improvement to this script would be to use a docker container instead of the /tmp directory.

@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch 2 times, most recently from 0d0d6da to 2615841 Compare December 21, 2020 09:38
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch from 2615841 to 832cb22 Compare March 26, 2021 22:11
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch from 832cb22 to 1d90352 Compare April 21, 2021 18:27
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch from 1d90352 to 4ea68da Compare August 30, 2021 14:14
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch from 4ea68da to 5e6a4a3 Compare February 8, 2022 12:14
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch from 5e6a4a3 to fc22ab0 Compare April 19, 2022 10:57
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch from fc22ab0 to c316892 Compare May 24, 2022 08:38
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch 2 times, most recently from 029d0ab to 12e7d81 Compare October 20, 2022 18:08
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch 4 times, most recently from 88e8e13 to 4b2f607 Compare December 9, 2022 12:30
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch from 4b2f607 to dbf5d81 Compare May 3, 2023 14:42
Mmuzaf
Mmuzaf reviewed Jul 24, 2023
View reviewed changes
cassandra-release/cassandra-check-release.sh
echo "====== CHECK RESULTS ======"
echo

gpg --import KEYS
Copy link

@Mmuzaf Mmuzaf Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it spoils the local gpg agent in case we don't want to import all the keys locally, so it should probably run inside a docker or we can prepare a docker image to do all checks :-)

Mmuzaf
Mmuzaf reviewed Jul 24, 2023
View reviewed changes
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch 3 times, most recently from 77e2240 to 3dad685 Compare August 14, 2023 11:50
Mmuzaf
Mmuzaf reviewed Aug 14, 2023
View reviewed changes
cassandra-release/cassandra-check-release.sh Outdated
command -v timeout >/dev/null 2>&1 || { echo >&2 "timeout needs to be installed"; exit 1; }
command -v docker >/dev/null 2>&1 || { echo >&2 "docker needs to be installed"; exit 1; }
(docker info >/dev/null 2>&1) || { echo >&2 "docker needs to running"; exit 1; }
(java -version 2>&1 | grep -q "1.8") || { echo >&2 "Java 8 must be used"; exit 1; }
Copy link

@Mmuzaf Mmuzaf Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this requirement as it will not work for 5.x releases, right? :-)

@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch from 3dad685 to bed5d51 Compare August 14, 2023 13:24
smiklosovic
smiklosovic reviewed Aug 15, 2023
View reviewed changes
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch from bed5d51 to 0e53ce4 Compare August 15, 2023 14:59
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch from 0e53ce4 to 5996107 Compare September 3, 2023 17:42
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch from 5996107 to f5a33a8 Compare September 4, 2023 20:32
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch 4 times, most recently from b119a93 to 52bc067 Compare July 18, 2024 13:17
@michaelsembwever
Copy link
Member Author

michaelsembwever commented Jul 18, 2024

Additions added so releases after they have been published can also be checked.

@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch 7 times, most recently from 2fbe264 to d859b6e Compare July 18, 2024 17:36
@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch 2 times, most recently from 333a269 to ab9a662 Compare July 21, 2024 12:22
@michaelsembwever michaelsembwever mentioned this pull request Aug 28, 2025
Closed
@smiklosovic
Copy link
Contributor

smiklosovic commented Aug 28, 2025 •
edited
Loading

this PR is a little bit obsolete by now, what I am using for 4.1 / 5.0.5 recently is in

https://github.com/apache/cassandra-builds/pull/119/files

simple "diff" will show the differences, mostly related to the fact this had to be added to the right places. It seems that by releasing Trixie they moved Buster to archive.debian.org.

    echo 'deb http://archive.debian.org/debian-security buster/updates main' >> /etc/apt/sources.list;
    echo 'deb http://archive.debian.org/debian buster main' > /etc/apt/sources.list;

plus this does not download Go my patch does.

@smiklosovic
Copy link
Contributor

smiklosovic commented Aug 28, 2025 •
edited
Loading

I would prefer if the author of this PR picked the changes I have mentioned above into this PR so there is one place we improve this at.

@michaelsembwever michaelsembwever force-pushed the mck/release-verification-script branch from ab9a662 to fa4b258 Compare August 29, 2025 09:10
@michaelsembwever
Copy link
Member Author

michaelsembwever commented Aug 29, 2025

I would prefer if the author of this PR picked the changes I have mentioned above into this PR so there is one place we improve this at.

done

JeremiahDJordan
JeremiahDJordan reviewed Oct 16, 2025
View reviewed changes
cassandra-release/cassandra-check-release.sh

###################

idx=`expr index "$2" -`
Copy link
Contributor

@JeremiahDJordan JeremiahDJordan Oct 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI osx has bsd expr which does not support the index command.

Copy link
Member Author

@michaelsembwever michaelsembwever Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this is the only problem in the script with it running on osx.

i think solving osx support would be better done by moving more into docker runs, as @Mmuzaf points out here: https://github.com/apache/cassandra-builds/pull/32/files/fa4b258da36445cd9afd92959a2637bac516c2d7#r1272464191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smiklosovic smiklosovic smiklosovic left review comments

@JeremiahDJordan JeremiahDJordan JeremiahDJordan left review comments

@Mmuzaf Mmuzaf Mmuzaf left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaelsembwever @smiklosovic @JeremiahDJordan @Mmuzaf