[CASSANDRA-20250][trunk] Optimize Counter, Meter and Histogram metrics using thread local counters #3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
February 6, 2025 00:37
CASSANDRA-20250
…sibility add a basic JMH test make ThreadLocalMetricsTest parametrized
add JMH for Meter implementations switch to approximate clock to reduce time retrieval overhead
…onentialMovingAverages, use single uncounted value for all 3 rates
move tickIfNessesary out from Meter.mark logic to a periodic background task remove LazySetArrayThreadLocalMetrics implementation, rename PiggybackArrayThreadLocalMetrics to ThreadLocalMetrics
use atomic long for hints in-procress counter which is frequently read introduce common Destroyable interface for metrics move cleanDeadAndUpdateSummaries invocations to a background thread and metric creation/destoying logic
…lity move ThreadLocalExponentialMovingAverages logic to ThreadLocalMeter itself
…ments, so we have to keep tick values per instance Fix condition in allocateRateGroupOffset Add dynamic Meter creation/destroying emulation
…jects associated with dead threads use BitSet for free metric id set Patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-20251
…ed to metrics and threads lifecycles Patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-20251
Patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-20251
Patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-20251
Patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-20251
clohfink
reviewed
Feb 24, 2025
|
unfortunately no, it is already LongAdder used in Dropwizard but it is not for free from CPU usage for our amount of metrics + it has a high memory overhead: CASSANDRA-20250 - here there is a long conversation with Benedict about it and different perf test results. |
|
A similar idea is also described by Nitsan: https://psy-lob-saw.blogspot.com/2013/06/java-concurrent-counters-by-numbers.html (as ThreadLocalCounter option) |
added 4 commits
March 2, 2025 18:55
… backward compatibility for Dropwizard MetricRegistryListener and Reporter functionality. Patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-20250
Patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-20250
Fix concurrency issues in writing from multiple threads to ThreadLocalMeter.rates Patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-20250
…ent class field separately Patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-20250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize Counter, Meter and Histogram metrics using thread local counters
Patch by Dmitry Konstantinov; reviewed by TBD for CASSANDRA-20250