CASSANDRA-21021 max level for ZstdDictionaryCompressor is 9#4475
Open
smiklosovic wants to merge 1 commit intoapache:trunkfrom
Open
CASSANDRA-21021 max level for ZstdDictionaryCompressor is 9#4475smiklosovic wants to merge 1 commit intoapache:trunkfrom
smiklosovic wants to merge 1 commit intoapache:trunkfrom
Conversation
yifan-c
reviewed
Nov 18, 2025
Contributor
yifan-c
left a comment
There was a problem hiding this comment.
I would like to share more context.
Looking at https://github.com/facebook/zstd/blob/dev/lib/compress/clevels.h, the srcSize plays a big role in memory consumption. srcSize is the size of the uncompressed data.
In the case of smaller than 16 KiB, even level 22 does not use much memory.
I am not sure what best decision to make :) Would like to here from you too.
| */ | ||
| public class ZstdCompressor extends ZstdCompressorBase implements ICompressor | ||
| { | ||
| public static final int BEST_COMPRESSION_LEVEL = Zstd.maxCompressionLevel(); |
Contributor
There was a problem hiding this comment.
Thank you for making ZstdCompressor backward compatible!
Maybe add a comment to explain why there are 2 different BEST_COMPRESSION_LEVEL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira