-
Notifications
You must be signed in to change notification settings - Fork 7
CS Installer #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CS Installer #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a comprehensive bash installer script for Apache CloudStack that supports multiple Linux distributions and provides an interactive dialog-based interface for component selection and configuration.
Key Changes
- Interactive installation wizard using dialog utility for component selection
- Multi-distribution support (Ubuntu/Debian and RHEL/CentOS/Fedora families)
- Automated configuration of CloudStack components including Management Server, KVM Agent, MySQL, and NFS storage
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 12 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
shwstppr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sudo87 looks promising!
Added some comments.
Some generic suggestions:
- Keep helper methods together in the file and group methods for a particular component - system, agent, management server, usage server, etc
- Define constants for the values used multiple times
- If possible try to generalize strings, XXX completed, XXX failed. Then maybe you can call a method with step name
|
@sudo87 also, it will be useful if you can update README with respect to your changes |
…ructure repo and network setup
…efore zone deployment
…r installed and configured components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shwstppr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
@sudo87 see if any of the new comments by Copilot need addressing
|
Thank you, @shwstppr, for taking the time to review! |
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds new CloudStack one line Installer based on "dialog" utility, takes user through wizard like mode setting up CloudStack.
It allows:
Notes:
Screenshots:
