Skip to content

Conversation

@sudo87
Copy link

@sudo87 sudo87 commented Aug 19, 2025

This PR adds new CloudStack one line Installer based on "dialog" utility, takes user through wizard like mode setting up CloudStack.

It allows:

  • All-in-one box installation (Management, Agent, Usage, NFS, MySQL)
  • Custom Installation
  • Setting up CS repo
  • Deployment of Zone

Notes:

  1. Management server and MySQL is installed in the same machine (Usage server as well)
  2. All-in-one box install is silent mode installation, default values are used for installation and zone deployment
  3. Installer is validated against Ubuntu 24.04, needs testing against OLE, Rocky etc.

Screenshots:
Screenshot 2025-10-27 at 10 42 48 AM

@DaanHoogland DaanHoogland requested a review from Copilot August 21, 2025 08:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a comprehensive bash installer script for Apache CloudStack that supports multiple Linux distributions and provides an interactive dialog-based interface for component selection and configuration.

Key Changes

  • Interactive installation wizard using dialog utility for component selection
  • Multi-distribution support (Ubuntu/Debian and RHEL/CentOS/Fedora families)
  • Automated configuration of CloudStack components including Management Server, KVM Agent, MySQL, and NFS storage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 12 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudo87 looks promising!

Added some comments.
Some generic suggestions:

  • Keep helper methods together in the file and group methods for a particular component - system, agent, management server, usage server, etc
  • Define constants for the values used multiple times
  • If possible try to generalize strings, XXX completed, XXX failed. Then maybe you can call a method with step name

@shwstppr
Copy link

@sudo87 also, it will be useful if you can update README with respect to your changes

@shwstppr shwstppr requested a review from Copilot November 3, 2025 11:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@sudo87 see if any of the new comments by Copilot need addressing

@sudo87
Copy link
Author

sudo87 commented Nov 5, 2025

Thank you, @shwstppr, for taking the time to review!

@sudo87 sudo87 requested a review from sureshanaparti November 5, 2025 07:53
Copy link

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants