-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zonewizard #67
base: main
Are you sure you want to change the base?
Zonewizard #67
Conversation
cloudstack/provider.go
Outdated
@@ -94,6 +94,7 @@ func Provider() terraform.ResourceProvider { | |||
ResourcesMap: map[string]*schema.Resource{ | |||
"cloudstack_affinity_group": resourceCloudStackAffinityGroup(), | |||
"cloudstack_autoscale_vm_profile": resourceCloudStackAutoScaleVMProfile(), | |||
"cloudstack_cluster": resourceCloudStackCluster(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work @poddm. I'll try testing these changes.
Do we also need to add "cloudstack_zone" here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harikrishna-patnala - cloudstack_zone was partially added in a previous merge. I extended the resource to support all of the fields and updated the ID from name to uuid.
Added additional resources
This also requires the following |
@poddm could you please help in resolving the conflicts |
Update - I'd still like to get these merged once the cloudstack SDK is updated. cloudstack go SDK changes |
@poddm can you address conflicts on the PR? |
@poddm can you review/rebase the PR & look at failing tests. Thanks. |
@rohityadavcloud @vishesh92. This is now rebased and updated to the latest cloudstack library. the ACC tests are failing here. Is there a way to bypass this storage pool check in the simulator? === RUN TestAccCloudStackStoragePool_basic
resource_cloudstack_storage_pool_test.go:29: Step 1/2 error: Error running apply: exit status 1
Error: CloudStack API error 530 (CSExceptionErrorCode: 9999): Failed to add data store: No host up to associate a storage pool with in cluster 1
with cloudstack_storage_pool.test,
on terraform_plugin_test.tf line 37, in resource "cloudstack_storage_pool" "test":
37: resource "cloudstack_storage_pool" "test" {
--- FAIL: TestAccCloudStackStoragePool_basic (53.68s)
FAIL
FAIL github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 55.537s
FAIL resource "cloudstack_storage_pool" "test" {
name = "acc_primarystorage1"
url = "nfs://10.147.28.6/export/home/sandbox/primary11"
zone_id = cloudstack_zone.test.id
cluster_id = cloudstack_cluster.test.id
pod_id = cloudstack_pod.test.id
scope = "CLUSTER"
hypervisor = "Simulator"
state = "Maintenance"
tags = "XYZ,123,456"
} |
Zone wizard resources:
Also, updated data source cloudstack_zone to work with the uuid vs. name (as the id).
--
Note -