Skip to content

Log previous and new value of configuration when reset/update API is called #10769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Apr 24, 2025

Description

This PR handles #5 scenario mentioned in #6880
During reset and update configuration, system will log existing and incoming value.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2025-04-22 18-09-00

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sudo87 sudo87 changed the title Log previous and new value of configuration before reset/update Log previous and new value of configuration when reset/update API is called Apr 24, 2025
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 41.46341% with 24 lines in your changes missing coverage. Please review.

Project coverage is 16.32%. Comparing base (193d6ef) to head (74a00c4).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
.../cloud/configuration/ConfigurationManagerImpl.java 41.46% 18 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10769   +/-   ##
=========================================
  Coverage     16.31%   16.32%           
- Complexity    13463    13468    +5     
=========================================
  Files          5676     5676           
  Lines        499391   499434   +43     
  Branches      60397    60397           
=========================================
+ Hits          81485    81519   +34     
+ Misses       408834   408833    -1     
- Partials       9072     9082   +10     
Flag Coverage Δ
uitests 3.99% <ø> (+<0.01%) ⬆️
unittests 17.18% <41.46%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13162

1. Change type for scope paramter for method updateConfiguration and validateConfigurationValue
2. Standardize scope variable to be of ConfigKey type and scopeVal as string
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sudo87
Copy link
Collaborator Author

sudo87 commented Apr 24, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants