Veeam: Use restore timeout as an interval as opposed to a counter

[Pearl1594]

Description

This PR fixes: #8165

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.87%. Comparing base (cd12fa5) to head (78a4b9a).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11772      +/-   ##
============================================
+ Coverage     17.50%   17.87%   +0.37%     
- Complexity    15425    16036     +611     
============================================
  Files          5894     5899       +5     
  Lines        526877   545432   +18555     
  Branches      64337    72356    +8019     
============================================
+ Hits          92232    97509    +5277     
- Misses       424269   437062   +12793     
- Partials      10376    10861     +485     

Flag	Coverage Δ
uitests	3.61% <ø> (+<0.01%)	⬆️
unittests	18.93% <100.00%> (+0.37%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15271

[DaanHoogland]

seems like the unit test needs an update as well:

https://github.com/apache/cloudstack/actions/runs/18215826235/job/51864745203?pr=11772#step:7:22893

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15303

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15305

[harikrishna-patnala]

code LGTM

[Copilot]

Pull Request Overview

This PR fixes the Veeam backup restore timeout mechanism by changing it from using a counter-based loop to a time-based interval approach, addressing issue #8165.

• Changed the timeout logic from a simple counter to use actual elapsed time measurement
• Updated test to use time-based verification instead of counting exact method calls
• Modified logging to show elapsed time instead of iteration count

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
VeeamClient.java	Replaces counter-based timeout with time-based elapsed time check using System.currentTimeMillis()
VeeamClientTest.java	Updates test to use time-based timeout value and flexible verification instead of exact call count

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
73.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[shwstppr]

code lgtm