agent: increase timeout for host arch retrieval #11822
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from 44f8064 Signed-off-by: Abhishek Kumar <[email protected]>
rohityadavcloud
requested review from
DaanHoogland,
shwstppr and
weizhouapache
|
@blueorangutan package |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11822 +/- ##
============================================
- Coverage 16.17% 16.17% -0.01%
- Complexity 13297 13298 +1
============================================
Files 5656 5656
Lines 498331 498331
Branches 60476 60476
============================================
- Hits 80591 80590 -1
- Misses 408767 408769 +2
+ Partials 8973 8972 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shwstppr
requested changes
Oct 10, 2025
| final Script command = new Script("/usr/bin/arch", 500, logger); | ||
| final OutputInterpreter.OneLineParser parser = new OutputInterpreter.OneLineParser(); | ||
| return command.execute(parser); | ||
| String arch = Script.runSimpleBashScript(Script.getExecutableAbsolutePath("arch"), 2000); |
There was a problem hiding this comment.
original PR had timeout as 1000 (base on my tests with OL8 x86_64 #11251 (comment)), this has 2000. Is there a new finding? Would it make sense to make this configurable then?
There was a problem hiding this comment.
@rohityadavcloud
would it be better same as #11254 ?
|
can you test the changes ? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 44f8064 from #11254
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?