-
Notifications
You must be signed in to change notification settings - Fork 1.2k
systemvm: fix duplicated "en_US.UTF-8 UTF-8" in /etc/locale.gen #11823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
@blueorangutan package |
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11823 +/- ##
=========================================
Coverage 16.17% 16.17%
- Complexity 13297 13301 +4
=========================================
Files 5656 5656
Lines 498331 498331
Branches 60476 60476
=========================================
+ Hits 80591 80602 +11
+ Misses 408767 408754 -13
- Partials 8973 8975 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15400 |
[SF] Trillian Build Failed (tid-14628) |
[SF] Trillian test result (tid-14629)
|
[SF] Trillian test result (tid-14630)
|
[SF] Trillian test result (tid-14627)
|
[SF] Trillian test result (tid-14626)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, are we sure “en_US.UTF-8 UTF-8” is always put on a new line in the cat statement? iirc yes, but my bash needs brushing up ;)
yes, if we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
[SF] Trillian test result (tid-14636)
|
[SF] Trillian test result (tid-14635)
|
@blueorangutan package |
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Description
We faced some issues with systemvm template on VMware 80u3 in the past
the issue is fixed by rebuilding the systemvm template
this issue appears again with last systemvm template for #11778
The issue seems to be caused by duplicated "en_US.UTF-8 UTF-8" in /etc/locale.gen
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?