kvm: fix ovs network creation issue

[weizhouapache]

Description

This PR fixes the issue below when create a ovs network

2024-10-29 16:02:45,089 WARN  [resource.wrapper.LibvirtOvsFetchInterfaceCommandWrapper] (agentRequest-Handler-2:null) (logid:e716722e) Network interface: ''cloudbr1'' not found

This is a regression of a previous security release
see "framework/cluster: improve cluster service, integration API server"

since we now use NetworkInterface.getByName to get network interface, we should NOT add single quotes before/after the label.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.08%. Comparing base (175eed2) to head (6a7255b).

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9869      +/-   ##
============================================
- Coverage     15.08%   15.08%   -0.01%     
  Complexity    11203    11203              
============================================
  Files          5404     5404              
  Lines        473423   473423              
  Branches      59987    59246     -741     
============================================
- Hits          71429    71428       -1     
- Misses       394044   394046       +2     
+ Partials       7950     7949       -1     

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.80% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[weizhouapache]

the OVS functionality is broken in the following releases

• 4.18.2.1
• 4.18.2.2
• 4.18.2.3
• 4.18.2.4
• 4.19.1.0
• 4.19.1.1
• 4.19.1.2

marked it as a BLOCKER

cc @rohityadavcloud @DaanHoogland @borisstoyanov @GutoVeronezi

[weizhouapache]

cc @rajujith

[weizhouapache]

@blueorangutan package

[weizhouapache]

@blueorangutan package

[sureshanaparti]

clgtm

[weizhouapache]

@blueorangutan LLpackage

[blueorangutan]

@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 6214

[weizhouapache]

@blueorangutan LLtest ubuntu22 kvm-ubuntu22

[blueorangutan]

@weizhouapache a [LL] Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests

[weizhouapache]

@blueorangutan LLtest alma8 kvm-alma8

[blueorangutan]

@weizhouapache a [LL] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests

[blueorangutan]

[LL]Trillian test result (tid-7040)
Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8
Total time taken: 47709 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9869-t7040-kvm-alma8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_unsecure_vm_migration	Error	394.85	test_vm_life_cycle.py
test_02_unsecure_vm_migration	Error	394.86	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	Error	0.01	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	Error	0.01	test_vm_life_cycle.py

[blueorangutan]

[LL]Trillian test result (tid-7038)
Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8
Total time taken: 52327 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9869-t7038-kvm-alma8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	Error	244.21	test_vm_life_cycle.py

[weizhouapache]

tested on centos7 and ubuntu 24 with OVS, looks good

cc @rohityadavcloud @DaanHoogland @GutoVeronezi

[shwstppr]

LGTM