Skip to content

Conversation

@anayw2001
Copy link
Contributor

Support files up to 8GiB in size for a single entry when using the OLD_ASCII format.

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

Copy link
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @anayw2001

Thank you for your PR. Do you have a canonical reference for 0x200000000L, like a URL to source? The Wikepedio entry for cpio seems to think the max is 8,589,934,591, and not 8,589,934,592.

@anayw2001
Copy link
Contributor Author

I don't actually! Wasn't sure if it was 8,589,934,592 or 8,589,934,591. Will bump this down to 8,589,934,591.

@anayw2001
Copy link
Contributor Author

Updated with the style fix and size fix.

@garydgregory
Copy link
Member

Support files up to 8GiB in size for a single entry when using the OLD_ASCII format.
@garydgregory garydgregory merged commit d2e3daf into apache:master Jan 20, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants