Skip to content

Conversation

@garydgregory
Copy link
Member

ByteArraySeekableByteChannel's position(long) and truncate(long) shouldn't throw an
IllegalArgumentException for a new positive position that's too large.

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we can add two small improvements.

@garydgregory garydgregory merged commit 208887b into apache:master Dec 8, 2025
21 checks passed
@garydgregory garydgregory deleted the bugfix/ByteArraySeekableByteChannel_position branch December 8, 2025 21:57
garydgregory added a commit that referenced this pull request Dec 8, 2025
…an IllegalArgumentException for a new positive position that's too large #817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants