LANG-1711: Skip inaccessible fields in ReflectionDiffBuilder#1557
Open
JeremySun0731 wants to merge 1 commit intoapache:masterfrom
Open
LANG-1711: Skip inaccessible fields in ReflectionDiffBuilder#1557JeremySun0731 wants to merge 1 commit intoapache:masterfrom
JeremySun0731 wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Hello @JeremySun0731
|
Author
|
Hi @garydgregory, Thanks for the feedback and for pointing me to PR #1558. I understand that a localized change in ReflectionDiffBuilder is not sufficient and that a package-wide, opt-in solution is preferred. I’ll take a look at #1558 and test it against the LANG-1711 scenario. Thanks for the guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes ReflectionDiffBuilder skip fields that cannot be accessed via reflection
instead of failing fast with an exception.
Previously, if reflective access to a field was denied (for example due to Java 9+ module
restrictions or security constraints), the diff process would abort entirely. This prevented
producing a partial diff even when most fields were accessible.
The implementation is limited to appendFields(...), where reflection access failures are
caught and ignored. This covers IllegalAccessException on Java 8 as well as runtime reflection
failures on newer Java versions. No public APIs were changed.
This keeps full Java 8 compatibility while improving robustness on restricted environments.
Related issue: LANG-1711