Update Elixir tests and config files #5822
Open
+731
−770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiahuili430
force-pushed
the
fix-elixir-tests
branch
3 times, most recently
from
969dc8b to
6d84623
Compare
jiahuili430
force-pushed
the
fix-elixir-tests
branch
from
6d84623 to
64ced76
Compare
jiahuili430
force-pushed
the
fix-elixir-tests
branch
2 times, most recently
from
42b2c15 to
54ab394
Compare
jiahuili430
changed the title
jiahuili430
force-pushed
the
fix-elixir-tests
branch
from
54ab394 to
c91c33f
Compare
big-r81
reviewed
Dec 12, 2025
| ], | ||
| "ReaderACLTest": [ | ||
| "unrestricted db can be read" | ||
| "JwtRolesClaimTest": [ |
Contributor
Author
There was a problem hiding this comment.
- This test was not included in the
suite.elixir, so it was never run in the CI before. - If adding this to the
suite.elixirfile, runningmake elixir tests=test/elixir/test/jwt_roles_claim_test.exswill fail locally.
$ make elixir tests=test/elixir/test/jwt_roles_claim_test.exs
...
Finished in 0.1 seconds (0.00s async, 0.1s sync)
5 tests, 5 failures
Contributor
Author
There was a problem hiding this comment.
ReplicationTest: they passed locally, but failed in CI.
- Elixir unit tests need to end with `_test.exs` to run. - large_docs_test.exs - reshard_changes_feed_test.exs - disk_monitor_test.exs - 04_key_test.exs - 25_beginswith_test.exs - The `Enum.each()` method cannot run tests because it iterates through the data at runtime, while the test macro is defined at compile time. Therefore, replace it with a for loop. - rewrite_js_test.exs - rewrite_test.exs - Update outdated tests. - cluster_with_quorum_test.exs - cluster_without_quorum_test.exs - cookie_auth_test.exs
- warning: variable "db" is unused (if the variable is not meant to be used, prefix it with an underscore). - friend_docs.ex - limit_docs.ex - warning: using single-quoted strings to represent charlists is deprecated. - user_docs.ex - warning: trailing commas are not allowed inside function/macro call arguments. - 02_basic_find_test.exs
- config/search.elixir - config/skip.elixir - config/suite.elixir
jiahuili430
force-pushed
the
fix-elixir-tests
branch
from
c91c33f to
ee1d058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Elixir unit tests need to end with
_test.exsto run.The
Enum.each()method cannot run tests because it iterates throughthe data at runtime, while the test macro is defined at compile time.
Therefore, replace it with a for loop.
Update outdated tests.
Update Elixir test config files.
Testing recommendations
make elixirmake elixir-searchRelated Issues or Pull Requests
Checklist
rel/overlay/etc/default.inisrc/docsfolder