Fix PersistentTtlNode not deleted if touch node is never created #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
reviewed
Apr 1, 2025
...-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java
Outdated
Show resolved
Hide resolved
...-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java
Outdated
Show resolved
Hide resolved
...-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java
Outdated
Show resolved
Hide resolved
...-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java
Outdated
Show resolved
Hide resolved
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentTtlNode.java
Outdated
Show resolved
Hide resolved
kezhuw
changed the title
kezhuw
reviewed
Apr 3, 2025
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentTtlNode.java
Outdated
Show resolved
Hide resolved
kezhuw
approved these changes
Apr 5, 2025
kezhuw
reviewed
Apr 7, 2025
There was a problem hiding this comment.
Would you want to take another look ? @tisonkun @eolivelli @Randgalt
It has been raised before in CURATOR-545, but end up in a fix in zookeeper side ZOOKEEPER-3546.
Given the fact that PERSISTENT_WITH_TTL is capable as CONTAINER node(see also
apache/zookeeper#1138 (comment)). I think we could create the container node with using PERSISTENT_WITH_TTL so we can fix this without reconfig server cluster.
Ideally, there sould be a "touch" command to modify "mtime" of PERSISTENT_WITH_TTL. Sadly, we don't have, so the child touch node still sound good to me as it does not setData on container node after creation.
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentTtlNode.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Kezhu Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1258 .
Thanks to Kezhu Wang for the suggestion in the solution