specs says type in header should at+jwt #990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
reviewed
Aug 22, 2022
| @@ -646,7 +647,12 @@ protected String processJwtAccessToken(JwtClaims jwtCliams) { | |||
| // It will JWS-sign (default) and/or JWE-encrypt | |||
| OAuthJoseJwtProducer processor = | |||
| getJwtAccessTokenProducer() == null ? new OAuthJoseJwtProducer() : getJwtAccessTokenProducer(); | |||
| return processor.processJwt(new JwtToken(jwtCliams)); | |||
|
|
|||
| JwsHeaders jwsHeaders = new JwsHeaders(); | |||
There was a problem hiding this comment.
@arthurchan35 it does not seem to be solving the problem at large:
- as you may see in the comment [1], it could be JWS or JWE
- for
JWE, theJwsHeadersare not used, theJweHeadersare
Looking into the right place to apply the spec recommendation, but on more general note, we need to introduce a member to JoseType for at+JWT and respective constant to JoseConstants.
There was a problem hiding this comment.
Hi @reta, thanks for the review!
According to RFC 9068 sections 2.1 and section 4, a JWT access token must be signed, optionally encrypted. As I interpret the comment, it means the same thing as specs required?
Regarding JoseType and JoseConstants, I will look into them bit more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datatracker.ietf.org/doc/html/rfc9068#section-2.1