-
Notifications
You must be signed in to change notification settings - Fork 246
feat:support ansi mode remainder function #2556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat:support ansi mode remainder function #2556
Conversation
@andygrove , @rishvin I created this PR to fix a bug which prevents executing CometRemainder function in ANSI mode |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2556 +/- ##
============================================
+ Coverage 56.12% 59.01% +2.89%
- Complexity 976 1457 +481
============================================
Files 119 146 +27
Lines 11743 13621 +1878
Branches 2251 2360 +109
============================================
+ Hits 6591 8039 +1448
- Misses 4012 4361 +349
- Partials 1140 1221 +81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @coderfender. Does the documentation also need updating?
@andygrove , I generally create a separate doc PR but given that this is a minor change, let me go ahead and make changes to update documentation as well |
LGTM. |
Do we need to prefix git message and PR title with "chore:" ? |
thank you for the review @andygrove , @rishvin . I updated documentation per review. |
Which issue does this PR close?
Closes #2555 .
Original ANSI support PR : #1971
Issue : #1971
Rationale for this change
What changes are included in this PR?
Update
CometRound
class and removegetSupportLevel
which is no longer relevantHow are these changes tested?
We already have ANSI tests which pass on this branch