-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Minor: include output partition count of RepartitionExec
to tree explain
#15717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me -- thank you @2010YOUY01
One thought i had was to make this even more concise by putting input / output partition counts on a single line
So instead of
39)┌─────────────┴─────────────┐
40)│ RepartitionExec │
41)│ -------------------- │
42)│ input_partition_count: │
43)│ 1 │
44)│ │
45)│ output_partition_count: │
46)│ 4 │
47)│ │
48)│ partitioning_scheme: │
49)│ RoundRobinBatch(4) │
50)└─────────────┬─────────────┘
More like
39)┌─────────────┴─────────────┐
40)│ RepartitionExec │
41)│ -------------------- │
42)│ partition_count(in->out): │
43)│ 1 -> 4 │
48)│ partitioning_scheme: │
49)│ RoundRobinBatch(4) │
50)└─────────────┬─────────────┘
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you update docs/source/user-guide/sql/explain.md
?
then I will close #15710
I also prefer this single-line format, updated |
I found it's not easy to update (and I don't think it's necessary to keep it in sync) |
Thanks @2010YOUY01 |
Which issue does this PR close?
Rationale for this change
Now output partition count is displayed inside
()
after partition scheme likeRoundRobin
This number's meaning is not obvious, this PR let this output partition count to be displayed separately
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?