Migrate Optimizer tests to insta, part5 #15945
Merged
+506
−498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs` to use snapshot assertions
…rs` to use snapshot assertions
qstommyshu
changed the title
… to use snapshot assertions
qstommyshu
changed the title
alamb
approved these changes
May 6, 2025
| @@ -243,48 +206,3 @@ macro_rules! assert_optimized_plan_eq_display_indent_snapshot { | |||
| Ok::<(), datafusion_common::DataFusionError>(()) | |||
| }}; | |||
| } | |||
|
|
|||
| pub fn assert_multi_rules_optimized_plan_eq_display_indent( | |||
There was a problem hiding this comment.
It seems like these are dead functions, but since they were marked pub the Rust compiler doesn't complain
|
I wonder if we are actually done now (❤️ thanks again @qstommyshu ) |
Not yet 😅. I just checked, there are at least 5 files in optimizer tests still needs to be migrated. |
So close! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
insta#15396 , Migrate Optimizer tests to insta, part1 #15446, Migrate Optimizer tests to insta, part2 #15884, Migrate Optimizer tests to insta, part3 #15893, Migrate Optimizer tests to insta, part4 #15937Rationale for this change
What changes are included in this PR?
This is the part 5 of #15396
Are these changes tested?
Yes, I manually tested the before/after changes.
Are there any user-facing changes?
No