Add test for ordering of predicate pushdown into parquet #16169
+117
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
|
@kosiew you seem to have a keen eye for API design and implementations of helper methods like this. I feel like the APIs here are currently a bit convoluted / redundant. At some point we'll want to audit real world usage and maybe redo them. Would you mind taking a look at this PR and giving feedback + any bigger picture thoughts you might have on how to implement these helpers? |
adriangb
force-pushed
the
fix-predicate-pushdown-bug
branch
from
f4287ce to
fc2ce21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was concerned that the dance we were doing with
allowed_filtersresulted in the order of filters being returned to the parent differing from the order they were passed down in.Luckily during the design of these APIs we ended up making them agnostic to the ordering of filters (hence why we pass the actual
PhysicalExprback up) so there is no bug 😄Nonetheless I decided to add tests, documentation and helpers to avoid this being a cause for confusion or a bug in the future.