feat: Implement SessionState::create_logical_expr_from_sql_expr
#18423
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petern48
force-pushed
the
create_logical_expr_from_sql_expr
branch
from
c718319 to
20f53ab
Compare
xudong963
reviewed
Nov 5, 2025
| let query = SqlToRel::new_with_options(&provider, state.get_parser_options()); | ||
|
|
||
| for sql in ["[1,2,3]", "a > 10", "SUM(a)"] { | ||
| let sql_expr = state.sql_to_expr(sql, &dialect).unwrap(); |
There was a problem hiding this comment.
The api name is strange to me first, I think it wants to say "sql string to expr"
There was a problem hiding this comment.
Yeah, it can be a bit ambiguous. Either way, sql_to_expr is an existing public API before this PR.
xudong963
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
SessionState::create_logical_expr_from_sql_expr#18278Rationale for this change
Convenience method for when parsing has already been done, and we want to start from a an expr object instead of SQL string.
What changes are included in this PR?
Are these changes tested?
Added test
Are there any user-facing changes?
Yes, new public api.