CI: add clippy::needless_pass_by_value rule

ci/scripts/rust_clippy.sh

@@ -19,3 +19,7 @@
 
 set -ex
 cargo clippy --all-targets --workspace --features avro,pyarrow,integration-tests,extended_tests -- -D warnings
+
+# Update packages incrementally for stricter Clippy checks
+# TODO: add tracking issue for the remaining workspace packages like `datafusion-catalog`
+cargo clippy -p datafusion-common --all-targets --features avro,pyarrow,parquet_encryption,sql -- -D warnings -W clippy::needless_pass_by_value

datafusion/common/src/column.rs

@@ -382,6 +382,7 @@ mod tests {
     use arrow::datatypes::{DataType, SchemaBuilder};
     use std::sync::Arc;
 
+    #[allow(clippy::needless_pass_by_value)]
     fn create_qualified_schema(qualifier: &str, names: Vec<&str>) -> Result<DFSchema> {
         let mut schema_builder = SchemaBuilder::new();
         schema_builder.extend(

datafusion/common/src/error.rs

@@ -1185,6 +1185,7 @@ mod test {
         Err(ArrowError::SchemaError("bar".to_string()).into())
     }
 
+    #[allow(clippy::needless_pass_by_value)]
     fn do_root_test(e: DataFusionError, exp: DataFusionError) {
         let e = e.find_root();
 

datafusion/common/src/file_options/parquet_writer.rs

@@ -478,6 +478,7 @@ mod tests {
         }
     }
 
+    #[allow(clippy::needless_pass_by_value)]
     fn extract_column_options(
         props: &WriterProperties,
         col: ColumnPath,

datafusion/common/src/hash_utils.rs

@@ -140,6 +140,7 @@ fn hash_array_primitive<T>(
 /// If `rehash==true` this combines the previous hash value in the buffer
 /// with the new hash using `combine_hashes`
 #[cfg(not(feature = "force_hash_collisions"))]
+#[allow(clippy::needless_pass_by_value)]
 fn hash_array<T>(
     array: T,
     random_state: &RandomState,

datafusion/common/src/scalar/mod.rs

@@ -4772,6 +4772,7 @@ impl fmt::Display for ScalarValue {
     }
 }
 
+#[allow(clippy::needless_pass_by_value)]
 fn fmt_list(arr: ArrayRef, f: &mut fmt::Formatter) -> fmt::Result {
     // ScalarValue List, LargeList, FixedSizeList should always have a single element
     assert_eq!(arr.len(), 1);
@@ -5568,6 +5569,7 @@ mod tests {
     }
 
     // Verifies that ScalarValue has the same behavior with compute kernel when it overflows.
+    #[allow(clippy::needless_pass_by_value)]
     fn check_scalar_add_overflow<T>(left: ScalarValue, right: ScalarValue)
     where
         T: ArrowNumericType,
@@ -7097,6 +7099,7 @@ mod tests {
     /// 1. convert to a `ScalarValue`
     /// 2. Convert `ScalarValue` back to an `ArrayRef`
     /// 3. Compare the original array (sliced) and new array for equality
+    #[allow(clippy::needless_pass_by_value)]
     fn round_trip_through_scalar(arr: ArrayRef) {
         for i in 0..arr.len() {
             // convert Scalar --> Array
@@ -7569,6 +7572,7 @@ mod tests {
     }
 
     // mimics how casting work on scalar values by `casting` `scalar` to `desired_type`
+    #[allow(clippy::needless_pass_by_value)]
     fn check_scalar_cast(scalar: ScalarValue, desired_type: DataType) {
         // convert from scalar --> Array to call cast
         let scalar_array = scalar.to_array().expect("Failed to convert to array");

datafusion/common/src/scalar/struct_builder.rs

@@ -83,6 +83,7 @@ impl ScalarStructBuilder {
     }
 
     /// Add the specified field and `ScalarValue` to the struct.
+    #[allow(clippy::needless_pass_by_value)]
     pub fn with_scalar(self, field: impl IntoFieldRef, value: ScalarValue) -> Self {
         // valid scalar value should not fail
         let array = value.to_array().unwrap();