Fix: topk_aggregate benchmark failing #18502
Open
+15
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Which issue does this PR close?
- Closes apache#18431
## Rationale for this change
The trace_id in the result is depended on a random number. I think
it's better to remove it from the sql to get a stable result
## What changes are included in this PR?
Remove the trace_id from the sql and the assert result
## Are these changes tested?
N/A
## Are there any user-facing changes?
No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
-The trace_id in the result is depended on a random number. I think
it's better to remove it from the sql to get a stable result
What changes are included in this PR?
Remove the trace_id from the sql and the assert result
Are these changes tested?
N/A
Are there any user-facing changes?
No