Skip to content

feat: Support planning subqueries with OuterReferenceColumn belongs to non-adjacent outer relations #19930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mkleen wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: Support planning subqueries with OuterReferenceColumn belongs to non-adjacent outer relations #19930

mkleen wants to merge 16 commits into from
+270 −87

Conversation

@mkleen
Copy link
Contributor

@mkleen mkleen commented Jan 21, 2026 •
edited
Loading

Which issue does this PR close?

Cleaned-up version of #18806 with:

Rationale for this change

See #18806

What changes are included in this PR?

See #18806

Are these changes tested?

Yes

Are there any user-facing changes?

outer_queries_schema is removed from PlannerContext.

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt) and removed sqllogictest SQL Logic Tests (.slt) labels Jan 21, 2026
@mkleen mkleen changed the title Plann recursive subquery cleanup feat: Support planning subqueries with OuterReferenceColumn belongs to non-adjacent outer relations Cleanup Jan 21, 2026
mkleen
mkleen commented Jan 21, 2026
View reviewed changes
datafusion/sql/tests/sql_integration.rs
Projection: l.a, l.b, l.c, l.d, l.e
SubqueryAlias: l
Projection: lineitem.l_item_id AS a, lineitem.l_description AS b, lineitem.price AS c
Projection: lineitem.l_orderkey AS a, lineitem.l_item_id AS b, lineitem.l_description AS c, lineitem.l_extendedprice AS d, lineitem.price AS e
Copy link
Contributor Author

@mkleen mkleen Jan 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because the lineitem table is extended now.

mkleen
mkleen commented Jan 21, 2026
View reviewed changes
datafusion/sql/tests/sql_integration.rs
"o1.o_custkey".to_string(),
"o1.o_orderstatus".to_string(),
"o1.customer_id".to_string(),
"o1.o_totalprice".to_string(),
Copy link
Contributor Author

@mkleen mkleen Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because the order table is extended now.

mkleen
mkleen commented Jan 21, 2026
View reviewed changes
datafusion/sql/tests/sql_integration.rs
assert_snapshot!(
err.strip_backtrace(),
@"Error during planning: Source table contains 3 columns but only 2 names given as column alias"
@"Error during planning: Source table contains 5 columns but only 2 names given as column alias"
Copy link
Contributor Author

@mkleen mkleen Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because the lineitem table is extended now.

mkleen
mkleen commented Jan 21, 2026
View reviewed changes
datafusion/sql/tests/common/mod.rs
])),
"orders" => Ok(Schema::new(vec![
Field::new("order_id", DataType::UInt32, false),
Field::new("o_orderkey", DataType::UInt32, false),
Copy link
Contributor Author

@mkleen mkleen Jan 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These extensions were necessary to get the tests to work.

@mkleen mkleen mentioned this pull request Jan 22, 2026
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 22, 2026
@mkleen
Fix trailing whitespace in CROSS JOIN logical plan formatting (#19936)
efccfb1 
## Which issue does this PR close?

While working on #19930 , I
noticed a trailing whitespace in the CROSS JOIN logical plan output.
This whitespace is inconsistent with the rest of the logical plan
formatting.

## Rationale for this change

This change removes the unnecessary trailing whitespace in the logical
plan output of a CROSS JOIN.

## What changes are included in this PR?

## Are these changes tested?

Yes.

## Are there any user-facing changes?

No.
@mkleen mkleen changed the title feat: Support planning subqueries with OuterReferenceColumn belongs to non-adjacent outer relations Cleanup feat: Support planning subqueries with OuterReferenceColumn belongs to non-adjacent outer relations Jan 23, 2026
@mkleen mkleen force-pushed the plann-recursive-subquery-cleanup branch from 99902bc to 3b1fa64 Compare January 23, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

logical-expr Logical plan and expressions sql SQL Planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Supporting planning (binding) Nested correlated subquery error with a depth exceeding 1

2 participants

@mkleen @duongcongtoai