perf: Optimize factorial scalar path #19949
Open
+45
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
approved these changes
Jan 23, 2026
| 6402373705728000, | ||
| 121645100408832000, | ||
| 2432902008176640000, | ||
| ]; // if return type changes, this constant needs to be updated accordingly |
Contributor
There was a problem hiding this comment.
Would be good to keep this comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The
factorialfunction currently converts scalar inputs to arrays before processing. Adding a scalar fast path avoids this overhead and improves performance.What changes are included in this PR?
invoke_with_argsto usematchstatement for handling both scalar and array inputsmake_scalar_functionusage.Are these changes tested?
Yes, covered by existing SLT tests:
scalar.sltlines 461-477math.sltline 797Are there any user-facing changes?