[Feature-16834] Start worker node with worker group label #16875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
requested review from
EricGao888,
caishunfeng,
ruanwenjun,
songjianet and
Gallardot
as code owners
ruanwenjun
reviewed
Dec 4, 2024
...r-master/src/main/java/org/apache/dolphinscheduler/server/master/cluster/WorkerClusters.java
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import lombok.EqualsAndHashCode; | ||
| import lombok.NoArgsConstructor; | ||
|
|
||
| @EqualsAndHashCode(callSuper = true) |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
ruanwenjun
reviewed
Dec 5, 2024
Comment on lines
154
to
156
| } else { | ||
| workerGroupMapping.put(workerServer.getWorkerGroup(), removeWorkerGroupAddrList); | ||
| } |
There was a problem hiding this comment.
Suggested change
| } else { | |
| workerGroupMapping.put(workerServer.getWorkerGroup(), removeWorkerGroupAddrList); | |
| } | |
| } |
No need to put again.
| @@ -126,6 +126,17 @@ WorkerServerMetadata parseServerFromHeartbeat(String serverHeartBeatJson) { | |||
| @Override | |||
| public void onServerAdded(WorkerServerMetadata workerServer) { | |||
| workerMapping.put(workerServer.getAddress(), workerServer); | |||
| synchronized (workerGroupMapping) { | |||
There was a problem hiding this comment.
Please add synchronized (workerGroupMapping) at onWorkerGroupDelete, onWorkerGroupAdd method.
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Gallardot
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16834
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md