Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Remove unused JDBCDataSourceProvider #16881

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

Clean the code.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun self-assigned this Dec 6, 2024
@ruanwenjun ruanwenjun requested a review from SbloodyS as a code owner December 6, 2024 04:05
@ruanwenjun ruanwenjun added this to the 3.3.0 milestone Dec 6, 2024
@ruanwenjun ruanwenjun removed the test label Dec 6, 2024
Copy link

sonarqubecloud bot commented Dec 6, 2024

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 0d9dba2 into apache:dev Dec 7, 2024
72 of 73 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_removeJDBCDataSourceProvider.java branch December 7, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants