Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16884] Using transaction when fetch command to avoid fetch command from slave database #16885

Merged

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

close #16884

Brief change log

  • Using transaction when fetch command and detecate worker group

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun self-assigned this Dec 6, 2024
@ruanwenjun ruanwenjun added the bug Something isn't working label Dec 6, 2024
@github-actions github-actions bot added backend and removed bug Something isn't working labels Dec 6, 2024
@ruanwenjun ruanwenjun added this to the 3.3.0 milestone Dec 6, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addTransactionWhenFetchCommand branch from 090754b to c6057c0 Compare December 6, 2024 11:15
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_addTransactionWhenFetchCommand branch from c6057c0 to f555c7e Compare December 6, 2024 11:19
Gallardot
Gallardot previously approved these changes Dec 6, 2024
SbloodyS
SbloodyS previously approved these changes Dec 6, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS added the bug Something isn't working label Dec 6, 2024
@ruanwenjun ruanwenjun dismissed stale reviews from SbloodyS and Gallardot via 27fc2ae December 6, 2024 12:19
@github-actions github-actions bot added the test label Dec 6, 2024
Copy link

sonarqubecloud bot commented Dec 8, 2024

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@ruanwenjun ruanwenjun merged commit 80c5f59 into apache:dev Dec 8, 2024
69 of 70 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_addTransactionWhenFetchCommand branch December 8, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] If MYSQL is configured in master/slave mode, we will query command from slave and delete at master.
3 participants