-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc-16755] Improve architecture description with JDBC and Etcd supportImprove design doc #17092
base: dev
Are you sure you want to change the base?
Conversation
With the correct changes, this PR improves the architecture documentation by reflecting newly supported JDBC and Etcd implementations. Please help review when convenient. Sorry again for my mistake. |
docs/docs/en/architecture/design.md
Outdated
ZooKeeper service, MasterServer and WorkerServer nodes in the system all use ZooKeeper for cluster management and fault tolerance. With evolving needs and modern deployment environments, DolphinScheduler now supports event monitoring and distributed locks not only based on ZooKeeper, but also on **JDBC** and **Etcd** implementations. | ||
|
||
- **JDBC** provides a lightweight solution for lock and event management through relational databases, making it ideal for simpler deployments or systems that already rely heavily on SQL databases. | ||
|
||
- **Etcd** enables distributed coordination using a high-performance key-value store, suitable for modern cloud-native environments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has nothing to do with Jdbc/Etcd implementation for event monitoring and distributed lock
. Just a simple description of JDBC
and Etcd
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your feedback, and I'm really sorry for the confusion. This is my very first PR, and I misunderstood the scope of this issue.
I thought the goal was to add a basic description of the newly supported JDBC and Etcd implementations.
I will now revise the PR to focus more on how DolphinScheduler technically supports JDBC/Etcd for event monitoring and distributed locking.
Thank you again for your patience and guidance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again for your feedback.
I’m really sorry for not fully understanding the requirement earlier.
I've now updated the documentation to include detailed implementation information for Etcd and JDBC, specifically explaining how they are used for event monitoring and distributed locking in DolphinScheduler.
…nd distributed lock
Purpose of the pull request
Improve the architecture documentation by adding JDBC and Etcd support information for event monitoring and distributed lock.
close #16755
Brief change log
Verify this pull request
This is a documentation-only change and does not require test verification.