Skip to content

[Fix-17356][Dependent] error creating Dependent #17357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 28, 2025
Merged

Conversation

SbloodyS
Copy link
Member

Purpose of the pull request

fix #17356

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@SbloodyS SbloodyS added this to the 3.3.1 milestone Jul 22, 2025
@SbloodyS SbloodyS self-assigned this Jul 22, 2025
@SbloodyS SbloodyS requested a review from EricGao888 as a code owner July 22, 2025 10:22
@SbloodyS SbloodyS added bug Something isn't working backend labels Jul 22, 2025
@SbloodyS SbloodyS requested review from Gallardot and ruanwenjun July 23, 2025 01:52
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to keep style with other table.

Seems we don't have pg e2e😢

@SbloodyS
Copy link
Member Author

SbloodyS commented Jul 23, 2025

It's better to keep style with other table.

Fixed. PTAL

Seems we don't have pg e2e😢

Yes, at the same time, we don't have the e2e of mysql, but h2 and mysql are completely compatible, so we avoid this in mysql.

@SbloodyS SbloodyS requested a review from ruanwenjun July 24, 2025 02:16
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS requested a review from zhongjiajie July 25, 2025 05:39
Copy link

@SbloodyS SbloodyS merged commit f81709c into apache:dev Jul 28, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Dependent] error creating Dependent
4 participants