-
Notifications
You must be signed in to change notification settings - Fork 4.9k
[Feature-17566][Helm] add secrets and initContainers in worker statefulset #17519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
@ruanwenjun could you review changes ? I have changed a better tittle but doesn't pass a couple of validators |
Please follow pull request notice and create an feature issue first. @jmmc-tools |
Sure, I open #17566 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @jmmc-tools
Do other components such as master or API-server also need this feature?
It's not mandatory to add more components for this feature request. The current scope focuses on the specific worker component, and extending it to master or API-server would be a separate consideration that could be evaluated in future iterations if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, we need to update the values.yaml file at the same time so that users know about this feature.
add secrets for worker statafulset in values yaml # Configuración existente del worker worker: enabled: true replicas: 3 # === NUEVA FUNCIONALIDAD: Soporte para secrets === # Opción 1: Un solo secret (recomendado para la mayoría de casos) # Este secret contendrá todas las variables de entorno necesarias envFromSecret: "git-sync-secret"
add feature to use initContainers in values yaml
|
[Feature-17566][Helm] update values example for secrets and initContainers
@Gallardot @ruanwenjun could you review values changes? thanks!! |
Closes #17566
=== NEW feature: secrets support ===
Configuration example in values.yaml
=== NEW feature: add use initContainers
Purpose of the pull request
This pull request adds new features in values yaml for worker pods from kubernetes:
Brief change log
Verify this pull request
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md