Skip to content

Conversation

jmmc-tools
Copy link

@jmmc-tools jmmc-tools commented Sep 16, 2025

Closes #17566

=== NEW feature: secrets support ===

Configuration example in values.yaml

worker:
  enabled: true
  replicas: 3
  # option: only 1 secret (for the most cases)
  # This secret have the all credential/token values need for use in worker pods.
  envFromSecret: "git-sync-secret"

=== NEW feature: add use initContainers

# Configuration example
worker:
  enabled: true
  replicas: 1
  # Init Container example in values.yaml
  initContainers:
    - name: secrets-decoder
      image: busybox:latest
      command:
        - /bin/sh
        - -c
        - |
          set -e
          echo "🔐 example initContainer for worker..."

Purpose of the pull request

This pull request adds new features in values yaml for worker pods from kubernetes:

  • initContainer
  • secretName

Brief change log

Verify this pull request

  • Manually verified the change by testing locally. -->

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

Copy link

boring-cyborg bot commented Sep 16, 2025

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@jmmc-tools jmmc-tools changed the title Update statefulset-dolphinscheduler-worker.yaml Improvement statefulset-dolphinscheduler-worker.yaml Sep 17, 2025
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Sep 20, 2025
@ruanwenjun ruanwenjun added this to the 3.3.2 milestone Sep 20, 2025
@jmmc-tools jmmc-tools changed the title Improvement statefulset-dolphinscheduler-worker.yaml [ Enhancement ] new feature: secrets and initContainers Sep 30, 2025
@jmmc-tools
Copy link
Author

@ruanwenjun could you review changes ? I have changed a better tittle but doesn't pass a couple of validators

@SbloodyS
Copy link
Member

SbloodyS commented Oct 5, 2025

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

Please follow pull request notice and create an feature issue first. @jmmc-tools

@jmmc-tools jmmc-tools changed the title [ Enhancement ] new feature: secrets and initContainers [ Feature ] [#17566] new feature: secrets and initContainers Oct 7, 2025
@jmmc-tools jmmc-tools changed the title [ Feature ] [#17566] new feature: secrets and initContainers [ Feature ] [ #17566 ] new feature: secrets and initContainers Oct 7, 2025
@jmmc-tools
Copy link
Author

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

Please follow pull request notice and create an feature issue first. @jmmc-tools

Sure, I open #17566

@SbloodyS SbloodyS changed the title [ Feature ] [ #17566 ] new feature: secrets and initContainers [Feature-17566 ][Helm] add secrets and initContainers in worker statefulset Oct 8, 2025
@SbloodyS SbloodyS changed the title [Feature-17566 ][Helm] add secrets and initContainers in worker statefulset [Feature-17566][Helm] add secrets and initContainers in worker statefulset Oct 8, 2025
Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jmmc-tools

Do other components such as master or API-server also need this feature?

@jmmc-tools
Copy link
Author

It's not mandatory to add more components for this feature request.

The current scope focuses on the specific worker component, and extending it to master or API-server would be a separate consideration that could be evaluated in future iterations if needed.

SbloodyS
SbloodyS previously approved these changes Oct 9, 2025
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS requested a review from ruanwenjun October 9, 2025 01:30
Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, we need to update the values.yaml file at the same time so that users know about this feature.

add secrets for worker statafulset in values yaml 

# Configuración existente del worker
worker:
  enabled: true
  replicas: 3
  
  # === NUEVA FUNCIONALIDAD: Soporte para secrets ===
  
  # Opción 1: Un solo secret (recomendado para la mayoría de casos)
  # Este secret contendrá todas las variables de entorno necesarias
  envFromSecret: "git-sync-secret"
add feature to use initContainers in values yaml
Copy link

sonarqubecloud bot commented Oct 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
57.5% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

ruanwenjun and others added 2 commits October 9, 2025 23:20
[Feature-17566][Helm] update values example for secrets and initContainers
@jmmc-tools
Copy link
Author

@Gallardot @ruanwenjun could you review values changes? thanks!!

@SbloodyS SbloodyS requested a review from Gallardot October 14, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement make more easy to user or prompt friendly kubernetes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Helm] add secrets and initContainers in worker statefulset

4 participants