[Fix-17780][TaskPlugin] Fix shell output log might loss due to incorrect usage of log buffer #17790
+94
−330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_fix17780
branch
from
90e47b1 to
e97029e
Compare
…ect usage of log buffer
ruanwenjun
force-pushed
the
dev_wenjun_fix17780
branch
from
e97029e to
efa563d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| String fileName = String.format("%s/%s_job.json", | ||
| taskExecutionContext.getExecutePath(), | ||
| taskExecutionContext.getTaskAppId()); | ||
| String fileName = String.format("%s/%s_job.json", taskRequest.getExecutePath(), taskRequest.getTaskAppId()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| String fileName = String.format("%s/%s_job.json", | ||
| taskExecutionContext.getExecutePath(), | ||
| taskExecutionContext.getTaskAppId()); | ||
| String fileName = String.format("%s/%s_job.json", taskRequest.getExecutePath(), taskRequest.getTaskAppId()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| String scriptFileName = String.format("%s/%s_node.sql", taskExecutionContext.getExecutePath(), | ||
| taskExecutionContext.getTaskAppId()); | ||
| String scriptFileName = String.format("%s/%s_node.sql", taskRequest.getExecutePath(), | ||
| taskRequest.getTaskAppId()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| return String.format("%s/seatunnel_%s.%s", taskExecutionContext.getExecutePath(), | ||
| taskExecutionContext.getTaskAppId(), formatDetector()); | ||
| return String.format("%s/seatunnel_%s.%s", taskRequest.getExecutePath(), | ||
| taskRequest.getTaskAppId(), formatDetector()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #17780
Brief change log
loghandler, since we don't need thisVerify this pull request
Verify by ci
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md