Skip to content

[fix](inverted index) reject null bytes in term middle to avoid stack overflow #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: clucene
Choose a base branch
from
+20 −0
Open

[fix](inverted index) reject null bytes in term middle to avoid stack overflow #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/core/CLucene/index/SDocumentWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,26 @@ void SDocumentsWriter<T>::ThreadState::FieldData::addPosition(Token *token) {
code = (code * 31) + tokenText[upto++];
uint32_t hashPos = code & postingsHashMask;

if (upto < tokenTextLen) {
for (int32_t i = upto; i < tokenTextLen; i++) {
if (tokenText[i] != CLUCENE_END_OF_WORD) {
char error_msg[512];
if constexpr (std::is_same_v<T, char>) {
snprintf(error_msg, sizeof(error_msg),
"Inverted index does not support terms with null byte (\\0) in the "
"middle. "
"Found null at position %d, but non-null character at position %d. "
"Term prefix: '%.*s'.",
upto, i, std::min(upto, 50), tokenText);
} else {
snprintf(error_msg, sizeof(error_msg),
"Term contains null character in the middle at position %d.", upto);
}
_CLTHROWA(CL_ERR_IllegalArgument, error_msg);
}
}
}

assert(!postingsCompacted);

// Locate Posting in hash
Expand Down
Loading